overridden: backoffice: Display call number for items #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpsherva
reviewed
Jun 14, 2024
| render() { | ||
| const { documentItems, isLoading, error } = this.props; | ||
| return ( | ||
| <Loader isLoading={isLoading}> |
There was a problem hiding this comment.
in invenio-app-ils you need to wrap this part with "DocumentItems.layout" which and pass this.renderTable as defined above. You will only override render function this way and avoid copying the whole component implementation, which is better for maintainability.
leave this part https://github.com/inveniosoftware/react-invenio-app-ils/pull/634/files#diff-18cb68f31fd99cfccf353466e41bb79106fcd071dfc552964bcfe7fa071a92f9R116 intact though, it is still a good improvement
kpsherva
reviewed
Jun 14, 2024
ui/src/overridableMapping.js
Outdated
| @@ -71,4 +72,5 @@ export const overriddenCmps = { | |||
| "Acquisition.OrderLine": OrderDetailsLine, | |||
| "DocumentCirculation.Extras": DocumentCirculationExtras, | |||
| "ItemCirculation.backoffice.shelf": ItemCirculationShelf, | |||
| "DocumentDetails.DocumentItems": DocumentItems, | |||
There was a problem hiding this comment.
Suggested change
| "DocumentDetails.DocumentItems": DocumentItems, | |
| "DocumentDetails.DocumentItems.layout": DocumentItemsLayout, |
Check my comment below for more details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #904